Skip to content

feat: update exception flag in cohort dist#782

Merged
will-larkin-nhs merged 5 commits intomainfrom
DTOSS-7725-update-exception-flag-in-cohort-dist
Mar 24, 2025
Merged

feat: update exception flag in cohort dist#782
will-larkin-nhs merged 5 commits intomainfrom
DTOSS-7725-update-exception-flag-in-cohort-dist

Conversation

@will-larkin-nhs
Copy link
Copy Markdown
Contributor

Description

  • create cohort distribution now updates the exception flag if a validation rule is triggered in the cohort rules
  • Now fatal & non-fatal rule triggered in cohort distribution will not be added to the cohort distribution table

Context

If a validation rule is triggered in cohort distribution we need to update the exception flag in participant management, this is not being done currently

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Comment thread application/CohortManager/compose.deps.yaml
Joseph2910
Joseph2910 previously approved these changes Mar 6, 2025
@stephhou stephhou added bug Something isn't working priority after freeze To be one of the first PRs merged after a code freeze labels Mar 6, 2025
@stephhou
Copy link
Copy Markdown
Contributor

stephhou commented Mar 6, 2025

Add priority after freeze label as this fixes rule 35 issue

@will-larkin-nhs will-larkin-nhs added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit 501e027 Mar 24, 2025
14 of 15 checks passed
@will-larkin-nhs will-larkin-nhs deleted the DTOSS-7725-update-exception-flag-in-cohort-dist branch March 24, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority after freeze To be one of the first PRs merged after a code freeze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants